[RuntimeAsync] Remove async TODOs where issues are not blocking and tracked in some other way #121766
+4
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes TODO comments related to async feature support (Multicore JIT, R2R, PGO, and EnC) that are already tracked in separate issues and are not currently blocking. The changes are purely documentation updates with no code behavior modifications.
- Removes tracked async variant TODOs from ReadyToRunInfo PGO and R2R entry point lookups
- Removes tracked async variant TODO from multicore JIT method recording
- Removes tracked async variant TODO from EnC (Edit and Continue) support
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/coreclr/vm/readytoruninfo.cpp | Removes two TODO comments before early returns for async variants in PGO instrumentation data retrieval and R2R entry point lookups |
| src/coreclr/vm/multicorejit.cpp | Removes TODO comment in the method preprocessing loop where async variant methods are skipped |
| src/coreclr/vm/class.cpp | Removes TODO comment before the EnC error log for async methods |
jkotas
reviewed
Nov 19, 2025
jkotas
reviewed
Nov 21, 2025
VSadov
commented
Nov 24, 2025
VSadov
commented
Nov 24, 2025
Co-authored-by: Jan Kotas <[email protected]>
jkotas
approved these changes
Nov 25, 2025
Member
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivial change removing some TODOs.
All these TODOs are for known NYIs that are not blocking and are all tracked in some other way.
Ex:
Multicore JIT: #115097
R2R: #121559
PGO: #121755